0.106.1: fix dynamic tuple encoding with boolean values #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joe-p
commented
Dec 18, 2024
joe-p
commented
- fixes dynamic tuple encoding with boolean values
error: stack underflow in box_put. at:68. Error during resource population simulation in transaction 0: transaction SH6U2CA7VLLXW3Z3WNIAJ4ISEDGQW255ES62AVCRT6BNOEWFTTEA: logic eval error: stack underflow in box_put. Details: app=1003, pc=133, opcodes=pop; concat; box_put
chore: recompile all with updated algod
Expected: [ 1n, 2n, 3n, false, [ "abcd", "efgh" ] ] Received: undefined
First problem of extra concat is solved, but now the problem is that the head offset is off by one byte (0x0024 with bool, 0x0025 with uint8). I think the problem is that the initial head offset is calculated before processing the boolean values, resulting in them not being accounted for in the offset.
fix: dynamic tuple encoding with boolean values
✅ Deploy Preview for tealscript ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.