Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: array-table/main.scss mixed-decls deprecation warning on [email protected] #4195

Open
wants to merge 1 commit into
base: formily_next
Choose a base branch
from

Conversation

veaba
Copy link

@veaba veaba commented Jul 30, 2024

image

see:
https://sass-lang.com/documentation/breaking-changes/mixed-decls/#example-mixed-declarations-opt-in-scss

warning report:

Deprecation Warning: Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.

More info: https://sass-lang.com/d/mixed-decls


47  │ ┌           &.#{$css-prefix}formily-item-warning-help {
48  │ │             color: $form-warning-color;
49  │ │           }
    │ └─── nested rule
... │
54  │             top: 100%;
    │             ^^^^^^^^^ declaration

    stdin 54:11  root stylesheet

issues

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

…77.7 +

see: 
https://sass-lang.com/documentation/breaking-changes/mixed-decls/#example-mixed-declarations-opt-in-scss

warning report:

```shell
Deprecation Warning: Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.

More info: https://sass-lang.com/d/mixed-decls

    ╷
47  │ ┌           &.#{$css-prefix}formily-item-warning-help {
48  │ │             color: $form-warning-color;
49  │ │           }
    │ └─── nested rule
... │
54  │             top: 100%;
    │             ^^^^^^^^^ declaration
    ╵
    stdin 54:11  root stylesheet
```

## issues
- sass/dart-sass#2280
- vitejs/vite#7116
@CLAassistant
Copy link

CLAassistant commented Jul 30, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants