Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatible with single letter camel naming #635

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wangruochan
Copy link

There are many Single-Letter-Camel Naming in OpenSource project, etc:HBase,XStream,BTrace,TEngine.

My commit modified the regex so that classnames can be named starting with any single capital letter

@wangruochan wangruochan requested a review from kerie January 16, 2020 03:53
@githubsoftware2015
Copy link

A problem occurred configuring project ':p3c-common'.

Could not resolve all files for configuration ':p3c-common:detachedConfiguration1'.
Could not download ideaIC.zip (com.jetbrains.intellij.idea:ideaIC:145.258.11)
> Could not get resource 'https://cache-redirector.jetbrains.com/www.jetbrains.com/intellij-repository/releases/com/jetbrains/intellij/idea/ideaIC/145.258.11/ideaIC-145.258.11.zip'.
> Read timed out
您好,这个应该怎么解决呢

@CLAassistant
Copy link

CLAassistant commented Mar 4, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


深秀 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@XenoAmess
Copy link

XenoAmess commented Apr 10, 2020

In short I disagree this pr.
IMO we shall think it deeper.
two reasons.
1.
The 'I' in original regex means Interface, which do have a special meaning.
There are actually basically two flows of programmers, one of them would like to name an interface "ISomeClass", another would like to name it "AbstractSomeClass".
And some guys will name abstract class to "AbstractSomeClass" and interface to "ISomeClass".
What I mean here is, the I means Interface here, and it is not a normal character.
What you want is actually change the grammar to allow other situations than it originally performs, that means a grammar change/rule change of p3c.
and if you want to change the rule, you shall change the rulebook first, then the next step we build the plugin to apply the rule.
you are doing it in a wrong order, guys.
2.
By the way,if you think HBase shall be acceptable, what is your idea about HTTPProtocolHandler?
Shall it be acceptable too?
Or not?
And why?
I mean, HTTPProtocolHandler is actually same as HBase in this question, as:
1.HTTP and Protocol are two words, H and Base are two words.
2.HTTP have a reason to be uppercase, H have a reason to be uppercase.
3.HTTPProtocol is meaningful, HBase is meaningful.

If you think HTTPProtocol is illegal just because it is too long, then what is the exact liminition number would you like?
for example, is FTPProtocol legal? is DPProtocol legal? is HProtocol legal?
I just want you think it deeper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants