bundle of updates/bugfix, dealing with2020.1 Beta #655
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in short, these fixs are for suiting idea 2020.1 Beta, also includes some bugfix and Deprecated codes migration.
I use p3c myself, and recently it looks buggy and print lots of stacktrace. It is unacceptable, so I come here to see what goes wrong.
Notice that I only fully tested the codes on 2020.1 beta(and done some very rough tests on older versions), so please retest it on older version by yourself when you get the pr.
1.(severe)
fix a bug that will throw a Throwable.
this bug is because you use ActionManager.getInstance() in CommonSettingsApplicationComponent, and ActionManager.getInstance() cannot be called in such state, thus the following codes will never run and a Throwable thrown.
As Component is Deprecated for a long time, I decide to migrate this class to StartupActivity, which is a far better option.
2.(light)
AccessToNonThreadSafeStaticFieldFromInstanceInspectionBase is deprecated and change it to AccessToNonThreadSafeStaticFieldFromInstanceInspection
3.(medium)
p3c-cmd/pom.xml has a duplicated plugin.
you plugin it two times and I do not see any value in doing so.
just deleted it.
4.(severe)
ArrayEqualityFix.getFamilyName() is totally wrong.
It is a dead recursion.
Fixed it.
5.(light)
update gradle_jetbrains_version and kotlin_version.
6.(suggest)
test it and release as soon as possible.
Also I see you are hiring people...kind of impressive.