Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oro 5.0 Compatibility Fixes #36

Draft
wants to merge 2 commits into
base: 5.0
Choose a base branch
from
Draft

Oro 5.0 Compatibility Fixes #36

wants to merge 2 commits into from

Conversation

chrisaligent
Copy link
Contributor

  • Rewrite BraintreePaymentActionEvent to support Symfony 5.4
  • Rewrite Purchase event listeners to use getAction() instead of service tags
  • PHPCS/PHPStan fixes
  • Update README to reflect new requirements
  • Tidy up event_listeners.yml

@chrisaligent
Oro 5.0 Compatibility Fixes
acb9b96 
* Rewrite BraintreePaymentActionEvent to support Symfony 5.4
* Rewrite Purchase event listeners to use getAction instead of service tags
* PHPCS/PHPStan fixes
* Update README to reflect new requirements
* Tidy up event_listeners.yml
@chrisaligent chrisaligent requested review from AdamJHall and a team as code owners July 21, 2022 06:31
@chrisaligent chrisaligent self-assigned this Jul 21, 2022
@chrisaligent chrisaligent removed request for a team and AdamJHall July 21, 2022 06:34
@chrisaligent chrisaligent marked this pull request as draft July 21, 2022 06:34
@chrisaligent
Copy link
Contributor Author

NOTE: There are still numerous compatibility fixes required here due to Oro 5/Symfony 5 breaking changes.
Additional commits will be pushed to this branch during the upgrade.

@chrisaligent
Additional Oro 5.0 Compatibility Fixes and code cleanup
133657d 
* Update Twig template paths to new syntax
* Remove unnecessary PHPDocs
* Fix broken imports
* Add missing return types
* Make all setters chainable where needed
* Resolve all PHPCS/PHPStan warnings
* Whitespace fixes (inconsistent indentation)
* Rearrange getter/setter methods to match property order (where needed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdamJHall AdamJHall Awaiting requested review from AdamJHall AdamJHall will be requested when the pull request is marked ready for review AdamJHall is a code owner

Assignees

@chrisaligent chrisaligent

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chrisaligent