Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add iam:CreateServiceLinkedRole to allow API GW custom domain creation #51

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+8 −0
Open

add iam:CreateServiceLinkedRole to allow API GW custom domain creation #51

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed72493
add iam:CreateServiceLinkedRole to allow API GW custom domain creation
Jun 27, 2024
bd274a5
run prettier formatter
Jun 27, 2024
42b37db
restrict CreateServiceLinkedRole to API Gateway
Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion packages/serverless-deploy-iam/bin/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,17 @@ export class ServiceDeployIAM extends cdk.Stack {
{
name: "IAM",
resources: [(serviceRole.type as Role).roleArn],
actions: ["iam:PassRole"],
actions: [
"iam:PassRole",
],
},
{
name: "IAM",
prefix: `arn:aws:iam::${accountId}:role`,
qualifiers: ["*"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a wildcard? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find. Fixed, based on the actual usecase.

actions: [
"iam:CreateServiceLinkedRole"
],
},
{
name: "S3",
Expand Down
Loading