🐛 Prevent adapter from connecting to search #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aligent-lturner
approved these changes
Mar 18, 2024
aligent-lturner
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The classes DI injected into the indexer action class contain the elasticsearch adapter
\Magento\Elasticsearch\Model\Adapter\Elasticsearchwhich attempts to connect to the configured search engine when the object manager attempts to create it.However, in cases where elasticsearch is not used it causes a problem as the class that's requiring it also fails instantiation as described in #60
Ideally, this class shouldn't fail from being created so that the indexer is able to skip it when set in the admin.