Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instantiate adapter via factory #63

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Instantiate adapter via factory #63

merged 2 commits into from
Jun 25, 2024

Conversation

gowrizrh
Copy link
Contributor

@gowrizrh gowrizrh commented Jun 25, 2024 •
edited
Loading

instantiation happens after the config check so when the search
node isn't available / disabled in admin, it early returns.

the previous proxy approach worked but broke other things bc virtual
types of proxy types can't seem to have constructor arguments
overridden via dependency injection.

@gowrizrh
🔧 instantiate adapter via factory
556f3f0 
instantiation happens after the config check so when the search
node isn't available, it early returns.

the previous proxy approach worked but broke other things bc virtual
types of proxy types can't seem to have constructor arguments
overridden via dependency injection.
@gowrizrh gowrizrh merged commit eec77a6 into 3.x Jun 25, 2024
8 checks passed
@gowrizrh gowrizrh deleted the feature/adapter-clean-up branch June 29, 2024 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quangdo-aligent quangdo-aligent quangdo-aligent approved these changes

@aligent-lturner aligent-lturner Awaiting requested review from aligent-lturner

@brettlaishley brettlaishley Awaiting requested review from brettlaishley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gowrizrh @quangdo-aligent