Mi 85 move ms template from npm to pnpm #1089
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 9, 2024 14:25
kai-nguyen-aligent
requested changes
Oct 9, 2024
|
Look good to me! I would approve this now but it would be better to have DevOps' good eyes on this. |
kai-nguyen-aligent
approved these changes
Oct 11, 2024
|
@ryanrixxh we're going to be using yarn and nx instead of pnpm. Can we close this PR? |
|
@ryanrixxh We need to decline this PR as we'll not move to pnpm anymore :( |
|
Closing as we're no longer moving to pnpm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building off of the work in aligent/nx-serverless-deploy-pipe#10
Changes the serverless template to use pnpm for the build and dev commands. And some changes to the bitbucket pipeline yaml to make use of those commands, aswell as add some environment variables that the multi-manager serverless pipeline needs to function.