Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MICRO-26: Update to match new set up #229

Merged
merged 4 commits into from
Nov 23, 2023

Conversation

kai-nguyen-aligent
Copy link
Contributor

@kai-nguyen-aligent kai-nguyen-aligent commented Nov 21, 2023

This PR update the plugin to match with new set-up of the whole webapp solution.

  1. Instead of asking developer to add appUrl, the plugin will try to get that info from stack output. This serve well for both normal service and webapp as only the webapp output a domain. Developer will need to specify the output key of the domain. The default value for this output key is landingDomain to support serverless-lift.
  2. If developer does not specify description, the plugin will try to get description from resources.Description in serverless configuration.

@tvhees
Copy link
Contributor

tvhees commented Nov 23, 2023

@kai-nguyen-aligent actually this needs a version bump

@kai-nguyen-aligent kai-nguyen-aligent merged commit f3d444a into main Nov 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants