Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/micro 287 configurable error behaviour on registration #254

Merged

Conversation

tvhees
Copy link
Contributor

@tvhees tvhees commented Feb 9, 2024

If the backend is not deployed, registration calls made by this plugin will fail and the error thrown as a result blocks deployment entirely.

This PR adds an optional configuration flag to avoid throwing an error. Default behaviour is the same as before.

@tvhees tvhees requested a review from crispy101 February 9, 2024 04:51
@tvhees tvhees requested review from gowrizrh and a team as code owners February 9, 2024 04:51
Copy link

@crispy101 crispy101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvhees tvhees merged commit cc06b96 into main Feb 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants