-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ada Binding to Gnu Scientific Library #934
Ada Binding to Gnu Scientific Library #934
Conversation
index/gs/gsl/gsl-0.1.0-dev.toml
Outdated
@@ -0,0 +1,13 @@ | |||
name = "gsl" | |||
description = "Shiny new project" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @RajaSrinivasan, you should have a short description of your project here instead of the default Shiny new project
.
Thanks. Not even sure how that came about! Fixed it. Hope it was
resubmitted. regards, srini
…On Thu, Dec 14, 2023 at 7:52 AM Fabien Chouteau ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In index/gs/gsl/gsl-0.1.0-dev.toml
<#934 (comment)>
:
> @@ -0,0 +1,13 @@
+name = "gsl"
+description = "Shiny new project"
Hi @RajaSrinivasan <https://github.com/RajaSrinivasan>, you should have a
short description of your project here instead of the default Shiny new
project.
—
Reply to this email directly, view it on GitHub
<#934 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACZJWNCZHQBMKFVHDWFZHKLYJLY7FAVCNFSM6AAAAABATCYAAOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOOBRG42TAMJYGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
index/gs/gsl/gsl-0.1.0-dev.toml
Outdated
@@ -0,0 +1,13 @@ | |||
name = "gsl" | |||
description = "Ada binding to Gnu Scientific Library 2.7" | |||
version = "0.1.0-dev" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This most likely wants to simply be 0.1.0
(with the filename fixed accordingly).
Separate issue: doesn't this depend on libgsl
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should I re start the whole process?
yes. this does require libgsl. The gpr file(s) indicate appropriate switches for Linux and MAC. I don't test this on windows.
some guidance will be good. regards, srini
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to restart. Just amend the manifest in this PR and push the changes.
Since libgsl
is already indexed, you need only to add the dependency on the proper version:
[[depends-on]]
libgsl = "^2.7"
Thanks, for the fixes, @RajaSrinivasan . This is almost ready, the single failure is due to the compiler in Ubuntu LTS being to old to recognize 2022 features. You need to add a compiler restriction such as
It's possible GNAT 11 could work too, but I'm unsure. I saw that GNAT 12 succeeds in other checks so that's a safe choice. Up to you to dig a bit further. |
Thanks, @RajaSrinivasan |
Thinnish binding to gsl 2.7 with examples