Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ada Binding to Gnu Scientific Library #934

Merged
merged 5 commits into from
Jan 22, 2024

Conversation

RajaSrinivasan
Copy link
Contributor

Thinnish binding to gsl 2.7 with examples

@@ -0,0 +1,13 @@
name = "gsl"
description = "Shiny new project"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @RajaSrinivasan, you should have a short description of your project here instead of the default Shiny new project.

@RajaSrinivasan
Copy link
Contributor Author

RajaSrinivasan commented Dec 14, 2023 via email

@@ -0,0 +1,13 @@
name = "gsl"
description = "Ada binding to Gnu Scientific Library 2.7"
version = "0.1.0-dev"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This most likely wants to simply be 0.1.0 (with the filename fixed accordingly).

Separate issue: doesn't this depend on libgsl?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should I re start the whole process?

yes. this does require libgsl. The gpr file(s) indicate appropriate switches for Linux and MAC. I don't test this on windows.

some guidance will be good. regards, srini

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to restart. Just amend the manifest in this PR and push the changes.

Since libgsl is already indexed, you need only to add the dependency on the proper version:

[[depends-on]]
libgsl = "^2.7"

@mosteo
Copy link
Member

mosteo commented Jan 22, 2024

Thanks, for the fixes, @RajaSrinivasan . This is almost ready, the single failure is due to the compiler in Ubuntu LTS being to old to recognize 2022 features. You need to add a compiler restriction such as

[[depends-on]]
gnat = ">=12"

It's possible GNAT 11 could work too, but I'm unsure. I saw that GNAT 12 succeeds in other checks so that's a safe choice. Up to you to dig a bit further.

@mosteo
Copy link
Member

mosteo commented Jan 22, 2024

Thanks, @RajaSrinivasan

@mosteo mosteo merged commit 63bedf9 into alire-project:stable-1.2.1 Jan 22, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants