-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pla_util 2.1.1 #935
pla_util 2.1.1 #935
Conversation
@@ -0,0 +1,64 @@ | |||
# SPDX-License-Identifier: GPL-3.0-or-later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @serock, we don't expect copyright headers in release manifests. The authors and licenses of the projects are already documented in the manifest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Fabien-Chouteau, thank you for reviewing; the header has been removed.
[configuration] | ||
generate_c = false | ||
|
||
[build-profiles] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I missed that the first time, but you must not set build profiles in a release manifest.
@mosteo I am surprised that the CI didn't catch that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we have checks for that, as it is conceivably desirable for non-library crates. Making a note of it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Fabien-Chouteau , thanks again for reviewing; I removed the build profiles.
Initial release of pla_util crate.