Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pla_util 2.1.1 #935

Merged
merged 3 commits into from
Dec 20, 2023
Merged

pla_util 2.1.1 #935

merged 3 commits into from
Dec 20, 2023

Conversation

serock
Copy link
Contributor

@serock serock commented Dec 13, 2023

Initial release of pla_util crate.

@@ -0,0 +1,64 @@
# SPDX-License-Identifier: GPL-3.0-or-later
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @serock, we don't expect copyright headers in release manifests. The authors and licenses of the projects are already documented in the manifest.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Fabien-Chouteau, thank you for reviewing; the header has been removed.

[configuration]
generate_c = false

[build-profiles]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed that the first time, but you must not set build profiles in a release manifest.

@mosteo I am surprised that the CI didn't catch that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we have checks for that, as it is conceivably desirable for non-library crates. Making a note of it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Fabien-Chouteau , thanks again for reviewing; I removed the build profiles.

@Fabien-Chouteau Fabien-Chouteau merged commit f21e304 into alire-project:stable-1.2.1 Dec 20, 2023
15 checks passed
@serock serock deleted the pla-util branch December 21, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants