Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spurious -g causing excess rebuilds when building alr #1454

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

mosteo
Copy link
Member

@mosteo mosteo commented Sep 15, 2023

Passing -g to gprbuild via the Builder package resulted in -g being passed to all dependencies, which in turn caused alr build to always rebuild some dependencies because they saw different switches when compiled by themselves and in the context of alr.gpr.

We can always force a full debug build if wanted by adding -g to gprbuild, so removing this from alr.gpr to get rid of those rebuilds is preferable. Also, Alire itself is always build with -g (via the Compiler package in alire_common.gpr), so this removal changes nothing in Alire's regard.

@mosteo mosteo marked this pull request as ready for review September 15, 2023 13:02
@mosteo mosteo merged commit 428064e into alire-project:master Sep 18, 2023
12 checks passed
@mosteo mosteo deleted the fix/unwanted-rebuilds branch September 18, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants