Fix CI using deprecated version of actions/upload-artifact #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seb-MCaw
changed the title
.github/workflows/ci-appimage.yml
Outdated
| @@ -48,7 +48,7 @@ jobs: | |||
|
|
|||
| - name: Upload logs (if failed) | |||
| if: failure() | |||
| uses: actions/upload-artifact@master | |||
| uses: actions/upload-artifact@main | |||
There was a problem hiding this comment.
Why no actions/upload-artifact@v3 or actions/upload-artifact@v4 ?
There was a problem hiding this comment.
@main is the approach already used elsewhere, and will avoid the need for further changes if there are future deprecations (which I assumed was the justification).
I have just changed them all to @v4 (@v3 will be deprecated in November), which I agree is the recommended approach.
mosteo
approved these changes
Sep 9, 2024
Fabien-Chouteau
approved these changes
Sep 10, 2024
mosteo
pushed a commit
to mosteo/alire
that referenced
this pull request
Oct 8, 2024
…ject#1756) * Fix CI on Linux * Fix others * Use v4 tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes errors like this one due to
actions/upload-artifact@v1andactions/upload-artifact@v2being deprecated.All references have been changed to
actions/upload-artifact@v4.