Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix heap buffer overflow when running simulation #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix heap buffer overflow when running simulation #14

wants to merge 1 commit into from
+2 −2

Conversation

HeRaNO
Copy link
Contributor

@HeRaNO HeRaNO commented Nov 8, 2024

Close #6

@Huoyuan100861
Copy link
Collaborator

This change might affect the correctness of the generated tree node results, requiring validation.

@HeRaNO
Copy link
Contributor Author

HeRaNO commented Nov 13, 2024

I'm not sure about this change. But the overflow does exist. Formally, the operation % nodes.size() should be placed inside the index.

I will take a deeper look into it. Feel free to suppress this PR if you have a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Heap buffer overflow when running simulation
2 participants
@HeRaNO @Huoyuan100861