Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Slovene support 🇸🇮 #134

Merged
merged 10 commits into from
Nov 2, 2023
Merged

Add Slovene support 🇸🇮 #134

merged 10 commits into from
Nov 2, 2023

Conversation

jglaszka
Copy link
Collaborator

@jglaszka jglaszka commented Sep 21, 2023

Done:

  • Added slovenian support for IntegerConverter and BankingMoneyConverter
  • Added tests
  • Updated README.md

Related to #105

@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2023

Codecov Report

Merging #134 (f639f01) into master (fd31e93) will decrease coverage by 0.11%.
The diff coverage is 96.51%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff              @@
##             master     #134      +/-   ##
============================================
- Coverage     98.93%   98.82%   -0.11%     
- Complexity      489      513      +24     
============================================
  Files            73       76       +3     
  Lines          1964     2050      +86     
  Branches         75       79       +4     
============================================
+ Hits           1943     2026      +83     
- Misses           10       12       +2     
- Partials         11       12       +1     
Files Coverage Δ
...pl/allegro/finance/tradukisto/MoneyConverters.java 100.00% <100.00%> (ø)
...pl/allegro/finance/tradukisto/ValueConverters.java 100.00% <100.00%> (ø)
...allegro/finance/tradukisto/internal/Container.java 100.00% <100.00%> (ø)
...dukisto/internal/languages/SlovenePluralForms.java 100.00% <100.00%> (ø)
...isto/internal/languages/slovene/SloveneValues.java 97.67% <97.67%> (ø)
...uages/slovene/SloveneThousandToWordsConverter.java 87.50% <87.50%> (ø)

@jglaszka jglaszka merged commit c368d45 into master Nov 2, 2023
4 checks passed
@jglaszka jglaszka deleted the feature/slovenian-support branch November 2, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants