Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix R2 profile and errors #233

Merged
merged 6 commits into from
Jun 10, 2024
Merged

Fix R2 profile and errors #233

merged 6 commits into from
Jun 10, 2024

Conversation

2015aroras
Copy link
Contributor

This PR fixes 2 issues:

  • Using an AWS profile to authenticate doesn't work, since the profile name is passed to the S3 client rather than a session.
  • FileNotFoundError is not being thrown when the only issue is that the object does not exists.

@2015aroras 2015aroras requested review from dirkgr and epwalsh June 7, 2024 23:27
Copy link
Member

@epwalsh epwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@2015aroras
Copy link
Contributor Author

The tests are breaking because of the following error. I can't see the dataset on beaker myself. Any ideas @epwalsh?
beaker.exceptions.DatasetNotFound: 'petew/cached-path-readme': Make sure you're using a valid Beaker dataset ID or the *full* name of the dataset (with the account prefix, e.g. 'username/dataset_name')

@epwalsh
Copy link
Member

epwalsh commented Jun 10, 2024

@2015aroras yea the test fixture beaker dataset must have been deleted. I'll follow up with a separate PR to fix that.

@epwalsh
Copy link
Member

epwalsh commented Jun 10, 2024

Fixes the beaker test here: #234

@2015aroras 2015aroras merged commit a45c796 into main Jun 10, 2024
10 of 11 checks passed
@2015aroras 2015aroras deleted the shanea/fix-r2-profile branch June 10, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants