Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update adapter to work with author page queries #47

Merged
merged 3 commits into from
Dec 22, 2016

Conversation

jacklenox
Copy link
Contributor

@jacklenox jacklenox commented Dec 21, 2016

The WordPress.com Elasticsearch Post Document Schema doesn't have post_author.user_nicename, so this PR maps it to author_login.

This should work in all situations on WordPress.com because we prevent email addresses etc. being used as usernames during signup.

Fixes #46

@kasparsd
Copy link
Contributor

kasparsd commented Dec 21, 2016

Thanks @jacklenox. Maybe we could map user_login too?

'post_author.user_login' => 'author_login',

Update: looks like user_login isn't used anywhere by the ES filter builder so we don't really need it.

@jacklenox
Copy link
Contributor Author

Oh, thanks @kasparsd, yes good idea! I hadn't realised you had updated your PR. Apologies, I didn't mean to try to supersede it! I'll update this now with that too.

@jacklenox
Copy link
Contributor Author

Oh haha, I really should stop firing from the hip without reading things fully!

Update: looks like user_login isn't used anywhere by the ES filter builder so we don't really need it.

☹️

@mboynes
Copy link
Contributor

mboynes commented Dec 22, 2016

Thanks for putting this together!

@mboynes mboynes merged commit 574ff9c into alleyinteractive:master Dec 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants