Fix generation of paths of synced variables #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paths should be generated from the parent of the leaf node in the tree, not from the leaf and then stripping off the last '/'. Previous method fails when value include '/' characters. In one instance the excluded path list was being checked against entire path/value concatenation which then failed to exclude. Remove an unused global variable.
sparlane
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paths should be generated from the parent of the leaf node in the tree, not from the leaf and then stripping off the last '/'. Previous method fails when value include '/' characters.
In one instance the excluded path list was being checked against entire path/value concatenation which then failed to exclude.
Remove an unused global variable.