Add support for XML proxy nodes in a query #106
Conversation
schema.c
Outdated
| } | ||
|
|
||
| for (child = xmlFirstElementChild (xml); child; child = xmlNextElementSibling (child)) | ||
| found = _sch_xml_has_proxy (instance, schema, ns, child, depth + 1, flags); |
There was a problem hiding this comment.
I can't make much sense of a lot of this, but this looks a bit suspicious to me. Maybe should be OR of all found values or AND of them all?
There was a problem hiding this comment.
I have modified the for loop to exit as soon as found is set true. This will cascade back up to the top of the recursive routines. The proxy detection routines are based on the equivalent _sch_xml_to_gnode and _sch_path_to_gnode routines with the setting of the GNode tree nodes removed, so its not actually new code.
There was a problem hiding this comment.
I am not sure how to go about reviewing something like this. To truly do it justice would take hours I suspect. I have found one thing that might be an issue, but ultimately we are going to have to test the hell out of this I suspect... The last bug I fixed, I couldn't find a way to get to one of the pieces of code I changed, I have no idea how we are going to get coverage on some of this stuff.
XML proxy nodes allow a schema to branch to using a remote apteryx database for a query. This change works by checking if a proxy node exists in the supplied query and if so splits the query into two parts (1) the query path down to the proxy node, (2) the remaining remote query. The remote query can then be translated if required. The reverse process occurs with the query result.