Prevent deletion of RO leaf-lists #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The checks that were in the leaf processing code need to also be in the leaf-list section. That is to check the access (rw) and also if the leaves are hidden. If the leaf-list is ro and the user has asked to delete config-only then we also need to remove the leaves of the leaf-list from the tree otherwise we end up with a strange tree with what looks like values on the leaf-list list node.
tony-vanderpeet
approved these changes
Oct 9, 2024
blairsteven
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The checks that were in the leaf processing code need to also be in the leaf-list section. That is to check the access (rw) and also if the leaves are hidden.
If the leaf-list is ro and the user has asked to delete config-only then we also need to remove the leaves of the leaf-list from the tree otherwise we end up with a strange tree with what looks like values on the leaf-list list node.