Fix issues with "with-defaults" #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcampbell512
force-pushed
the
with-defaults
branch
2 times, most recently
from
6bceacc to
35ec7af
Compare
gcampbell512
force-pushed
the
with-defaults
branch
from
35ec7af to
5093d5d
Compare
Adding "with-defaults" "report-all" defaults is complex. A new routine
has been added ("sch_add_defaults") to handle the complexity.
Both the restconf and netconf code for processing "with-defaults" has
been changed to use the new routine in other commits.
The routine sch_traverse_tree has been simplified as it no longer requires
the depth parameter to handle special netconf trees.
gcampbell512
force-pushed
the
with-defaults
branch
from
5093d5d to
6b856d6
Compare
carlgsmith
approved these changes
Nov 12, 2024
tony-vanderpeet
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The netconf code for processing "with-defaults" has been aligned to be similar to the existing restconf code. In particular netconf is now only passing the part of the tree that needs to have the "with-defaults" modifications made to it.
A new routine has been added to detect if a query is only for leaf fields. In that case when "with-defaults" is set to report-all, there is no need to check if we need to add additional defaults.