Fix with defaults - report-all failing some netconf tests #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The with default handling for netconf was mostly copied from the equivalent apteryx-rest rest.c code. There are differences however between the way restconf and netconf return data. Restconf only returns information from the query end, but netconf returns a complete tree from the top of the model. This means the way the with-defaults is handled needs to change. The patch has been adapted based on the original commit authored by gcampbell512.
carlgsmith
approved these changes
Oct 25, 2023
carlgsmith
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The with default handling for netconf was mostly copied from the equivalent apteryx-rest rest.c code. There are differences however between the way restconf and netconf return data. Restconf only returns information from the query end, but netconf returns a complete tree from the top of the model. This means the way the with-defaults is handled needs to change.
The patch has been adapted based on the original commit authored by gcampbell512.