Handle apteryx_set_tree / apteryx_prune / apteryx_watch_tree as a tree #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new larger set tree with a watch. This is the target for upcoming tree callback matching.
Add cb_match_tree. This function returns a GList of struct cb_tree_info with the usual cb_info_t structure populated, with a newly allocated GNode tree of the data that matches the callback.
The new config_match_tree function allows us to match the whole change set in a set tree or prune against all watchers and validators. These callbacks can then be called with the matching tree as a single RPC - this can save a lot of processing for large changesets.
carlgsmith
reviewed
Sep 19, 2024
| } | ||
|
|
||
| /* We need to break a compound root up to match nicely. */ | ||
| if (root->data && strchr ((char*)root->data, '/')) |
There was a problem hiding this comment.
does this always get hit???? even if root="/" ?
Handle the unlikely case that the rpc_msg_decode_tree fails to build a tree.
…eryx_set_tree apteryx_set_tree and apteryx_query both check that the root key in the tree is a valid apteryx path. It handle this ensure that the GNode that is created when parsing the tree has a "/" if it is not a longer path.
carlgsmith
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintain GNode trees through apteryx_set_tree / apteryx_prune watch callback matching to improve performance (~50x) with large trees.