Apteryx uniqify tree #436
Merged
Apteryx uniqify tree #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a function to remove duplicate values from a tree - as a side effect this will sort each level of the tree in alphabetic order.
apteryx_query has an unusual behaviour in that some advanced queries can generate a tree with duplicate nodes. Remove these with apteryx_uniqify_tree.
This allows the g_node_prepend done in _rpc_msg_decode_tree to reassemble the tree in the same order as it was originally without being O(n*n).
Instated a check that now passes, made another test do what was intended.
Ensure a client setting up multiple values for the same key in a tree ends up with the last value actually being used. There are ways of doing this setup which will end up with the wrong value being set (requiring a mix of methods to create the tree), but this will work when APTERYX_VALUE / APTERYX_NODE is used the same way multiple times to create a tree with duplicate nodes.
carlgsmith
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.