Add locking to NIOCTXSYNC and NIOCRXSYNC ioctl #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A crash can occur if rx/txsync is happening at the same time as the rings are being released. The find_priv_from_na call should be within locks as it can access data that will be under contention.
thomasjwinter
force-pushed
the
974b68c0-atl
branch
from
f2c1296 to
4a2e40d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A crash can occur if rx/txsync is happening at the same time as the rings are being released.
The NIOCTXSYNC and NIOCRXSYNC ioctls should be within locks as the functions they call may access data that will be under contention.