Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use reputer nonce as latestAvailable #730

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

xmariachi
Copy link
Contributor

@xmariachi xmariachi commented Dec 23, 2024

Purpose of Changes and their Description

GetLatestAvailableNetworkInferences currently gets the latest inferences in allInferences but doesn't check if there are losses set for that particular nonce (it does check if there is some reputer nonce set in the past though)
This PR changes it to get the network inferences from the latest reputer token, which changes the Available concept to those having had reputation.
Not sure if this is the expected behaviour, so leaving impl as Draft with a test that is not yet working, will fix when we align here.

Link(s) to Ticket(s) or Issue(s) resolved by this PR

Are these changes tested and documented?

  • If tested, please describe how. If not, why tests are not needed.
  • If documented, please describe where. If not, describe why docs are not needed.
  • Added to Unreleased section of CHANGELOG.md?

Still Left Todo

Fill this out if this is a Draft PR so others can help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant