Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fix config.js #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lordofdegen
Copy link

Hey, nice to meet you! Hope you are doing well. I’ve tried fixing a few issues, and I hope my solution works for you.

##What was before

#1 Error handling when reading mnemonic file
The code reads the mnemonic file without checking if it exists or handling potential errors. If the file is missing or empty, the program crashes.

#2 Incorrect handling of mnemonics
The code tries to extract a substring from the first mnemonic without checking its length. If the string is shorter than 15 characters, it throws an error.

##What became of the fixes

#1 Now there's a file existence check and proper error handling.

#2 Now the string length is checked before calling substring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant