Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, nice to meet you! Hope you are doing well. I’ve tried fixing a few issues, and I hope my solution works for you.
##What was before
#1 Error handling when reading mnemonic file
The code reads the mnemonic file without checking if it exists or handling potential errors. If the file is missing or empty, the program crashes.
#2 Incorrect handling of mnemonics
The code tries to extract a substring from the first mnemonic without checking its length. If the string is shorter than 15 characters, it throws an error.
##What became of the fixes
#1 Now there's a file existence check and proper error handling.
#2 Now the string length is checked before calling
substring
.