Initial commit of alloy-js/csharp #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes basic functionality including namespaces, classes and members, enums and members, and using directives with refkey support.
@alloy-js/babel-plugin-alloy
@alloy-js/babel-plugin-jsx-dom-expressions
babel-preset-alloy
@alloy-js/core
@alloy-js/java
@alloy-js/prettier-plugin-alloy
@alloy-js/csharp
@alloy-js/typescript
commit: |
bterlson
reviewed
Sep 6, 2024
| return <core.Declaration symbol={thisClassSymbol}> | ||
| {csharp.getAccessModifier(props.accessModifier)}class <base.Name />{props.children ? ( | ||
| <> | ||
| {"\n{"} |
There was a problem hiding this comment.
I think you should be able to include just an empty line? If not, that's a bug.
There was a problem hiding this comment.
You can also consider a component which adds the braces for you, slightly more characters than {"{"} but less annoying to type maybe.
There was a problem hiding this comment.
Empty line does work.
What's the idiom here? Having a blank line looks weird to me but if that's what folks do then I'll follow suit.
bterlson
reviewed
Sep 6, 2024
bterlson
reviewed
Sep 6, 2024
bterlson
approved these changes
Sep 6, 2024
improve some element names
it generates the csproj file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes basic functionality including namespaces, classes and members, enums and members, and using directives with refkey support.