Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos: patch solc 0.7.6, first dynamically-linked version #82

Merged
merged 1 commit into from
Apr 12, 2023
Merged

nixos: patch solc 0.7.6, first dynamically-linked version #82

merged 1 commit into from
Apr 12, 2023

Conversation

andrevmatos
Copy link
Contributor

@andrevmatos andrevmatos commented Apr 6, 2023 •
edited
Loading

From #48 (comment)

solc 0.7.6 was the first version to be dynamically-linked against ld loader, and therefore doesn't work on NixOS.

mattsse
mattsse approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

@andrevmatos
Copy link
Contributor Author

@roynalnaruto can you give a look at this, since you reviewed previous PR? should be simple enough. Thanks

@roynalnaruto roynalnaruto merged commit ca3d131 into alloy-rs:master Apr 12, 2023
@andrevmatos andrevmatos deleted the nixos/solc_0.7.6 branch May 5, 2023 16:26
@andrevmatos andrevmatos mentioned this pull request May 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrevmatos @mattsse @roynalnaruto