Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example docker-compose with proxy auth variables #447

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

drajabr
Copy link

@drajabr drajabr commented Feb 11, 2024

Added proxy auth variables
Changed docker bind port to 8888 instead of 80, as it will almost always be occupied.

Usually, if someone is using docker for other than local testing will be using a reverse proxy to access applications, and most of the time also for authentication. So added the required environment variables to work with proxy auth.
Added proxy auth variables and changed the default port.
Edit: default docker forwarding port not to colloid with the proxy
Copy link
Owner

@almarklein almarklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I made some comments and suggestions. Most also apply to the other file.

deploy/docker-compose.nonroot.yml Outdated Show resolved Hide resolved
deploy/docker-compose.nonroot.yml Outdated Show resolved Hide resolved
deploy/docker-compose.nonroot.yml Outdated Show resolved Hide resolved
deploy/docker-compose.nonroot.yml Show resolved Hide resolved
@drajabr
Copy link
Author

drajabr commented Feb 12, 2024

Even though its a little contribution, but I'm happy for it! Wish I can help more :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants