Fix Capture.watchStream to respect default text encoding #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, buffer may contain truncated UTF-8 characters at the end, resulting in invalid characters in the subsequent String constructor. By using InputStreamReader, we can specify the default encoding used by the String constructor so buffer will not split the bytes for a single character.
|
This PR arrived a bit before the revamping of jupyter-scala, under the "almond" name. I guess ensuring almond works fine on Windows should fix that... (There are a number of issues with the windows tag.) Keeping this PR open as a reminder to check if the corresponding code in almond was changed once the windows issues are addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, buffer may contain truncated UTF-8 characters at the end, resulting in invalid characters in the subsequent String constructor. By using InputStreamReader, we can specify the default encoding used by the String constructor so buffer will not split the bytes for a single character.