Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional ground nogoods generated for choice rules #284

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rtaupe
Copy link
Collaborator

@rtaupe rtaupe commented Dec 16, 2020

This is an alternative approach to #282 which aims for the same goal. In comparison, this pull request is (at least currently) less cleanly implemented, but is more efficient (because ground binary nogoods are directly created instead of generating constraints which lead to larger nogoods).

For a discussion, see #282.

@codecov
Copy link

codecov bot commented Dec 16, 2020

Codecov Report

Merging #284 (c468c80) into master (1fbbbf0) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #284      +/-   ##
============================================
+ Coverage     77.46%   77.48%   +0.02%     
- Complexity     2312     2316       +4     
============================================
  Files           178      179       +1     
  Lines          7782     7792      +10     
  Branches       1352     1353       +1     
============================================
+ Hits           6028     6038      +10     
  Misses         1334     1334              
  Partials        420      420              
Impacted Files Coverage Δ Complexity Δ
...uwien/kr/alpha/common/NegativeChoicePredicate.java 100.00% <100.00%> (ø) 3.00 <3.00> (?)
...t/ac/tuwien/kr/alpha/grounder/NoGoodGenerator.java 98.48% <100.00%> (+0.12%) 24.00 <0.00> (+1.00)
...ha/grounder/transformation/ChoiceHeadToNormal.java 85.00% <100.00%> (ø) 7.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fbbbf0...c468c80. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant