Skip to content

Commit

Permalink
Fix: Saving of org-ql-view views
Browse files Browse the repository at this point in the history
It didn't seem that calling custom-save-all was necessary in the past,
but it appears that it is now.

Closes #378.

Reported-by: Pentaquark1 <https://github.com/Pentaquark1>
  • Loading branch information
alphapapa committed Oct 20, 2023
1 parent 4476759 commit 09c3591
Show file tree
Hide file tree
Showing 3 changed files with 40 additions and 34 deletions.
1 change: 1 addition & 0 deletions README.org
Original file line number Diff line number Diff line change
Expand Up @@ -546,6 +546,7 @@ Simple links may also be written manually in either sexp or non-sexp form, like:

*Fixes*
+ Disable ~case-fold-search~ when collecting headings in outline paths. (Headings that started with a word that is also a to-do keyword but with different capitalization would be matched incorrectly.)
+ Saving of ~org-ql-view~ views. ([[https://github.com/alphapapa/org-ql/issues/378][#378]]. Thanks to [[https://github.com/Pentaquark1][Pentaquark1]] for reporting.)

** 0.7.2

Expand Down
6 changes: 4 additions & 2 deletions org-ql-view.el
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,8 @@ update search arguments."
(yes-or-no-p (format "Overwrite view \"%s\"?" name)))
(setf (map-elt org-ql-views name nil #'equal) plist)
(customize-set-variable 'org-ql-views org-ql-views)
(customize-mark-to-save 'org-ql-views))))
(customize-mark-to-save 'org-ql-views)
(custom-save-all))))

(defun org-ql-view-delete ()
"Delete current view (with confirmation)."
Expand All @@ -362,7 +363,8 @@ update search arguments."
(--remove (equal (car it) org-ql-view-title)
org-ql-views))
(customize-set-variable 'org-ql-views org-ql-views)
(customize-mark-to-save 'org-ql-views)))
(customize-mark-to-save 'org-ql-views)
(custom-save-all)))

(defun org-ql-view-customize ()
"Customize view at point in `org-ql-view-sidebar' buffer."
Expand Down
67 changes: 35 additions & 32 deletions org-ql.info
Original file line number Diff line number Diff line change
Expand Up @@ -1034,6 +1034,9 @@ File: README.info, Node: 073-pre, Next: 072, Up: Changelog
paths. (Headings that started with a word that is also a to-do
keyword but with different capitalization would be matched
incorrectly.)
• Saving of ‘org-ql-view’ views. (#378
(https://github.com/alphapapa/org-ql/issues/378). Thanks to
Pentaquark1 (https://github.com/Pentaquark1) for reporting.)


File: README.info, Node: 072, Next: 071, Prev: 073-pre, Up: Changelog
Expand Down Expand Up @@ -1796,38 +1799,38 @@ Node: Links37271
Node: Tips37958
Node: Changelog38282
Node: 073-pre39081
Node: 07239410
Node: 07140333
Node: 0741142
Node: 06344066
Node: 06244597
Node: 06144902
Node: 0645470
Node: 05248524
Node: 05148824
Node: 0549249
Node: 04950780
Node: 04851062
Node: 04751411
Node: 04651820
Node: 04552228
Node: 04452589
Node: 04352948
Node: 04253151
Node: 04153312
Node: 0453559
Node: 03257660
Node: 03158063
Node: 0358260
Node: 02361560
Node: 02261794
Node: 02162074
Node: 0262279
Node: 0166357
Node: Notes66458
Node: Comparison with Org Agenda searches66620
Node: org-sidebar67509
Node: License67788
Node: 07239591
Node: 07140514
Node: 0741323
Node: 06344247
Node: 06244778
Node: 06145083
Node: 0645651
Node: 05248705
Node: 05149005
Node: 0549430
Node: 04950961
Node: 04851243
Node: 04751592
Node: 04652001
Node: 04552409
Node: 04452770
Node: 04353129
Node: 04253332
Node: 04153493
Node: 0453740
Node: 03257841
Node: 03158244
Node: 0358441
Node: 02361741
Node: 02261975
Node: 02162255
Node: 0262460
Node: 0166538
Node: Notes66639
Node: Comparison with Org Agenda searches66801
Node: org-sidebar67690
Node: License67969

End Tag Table

Expand Down

0 comments on commit 09c3591

Please sign in to comment.