Speedup and fix umount #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip some steps that are only needed the first time the chroot is created.
Only unmount mount points starting but not equal to the root. Fix alpinelinux#30
|
I merged the second commit, “Fix umount”, as 8f12e62. Thanks! I don’t have time to review the first one right now, I’ll come back to it later. |
|
Thanks, that was the most important one anyway. Since that PR I switched to a simple chroot based on the official minirootfs so I don't really need the speed boost anymore. Doing something simiar for alpine-chroot-install would also fix that #27 and AFAICT it does not need some key setup shenanigan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #30 and #31