install ALPINE_BASE_PKGS first if requested #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a package has a pre-install script that adds users, the pre-install actually requires alpine-baselayout-data/busybox to successfully work, but this dependency isn't written anywhere. After bringing this up on IRC rather than adding the dependency everywhere it was decided to make sure alpine-baselayout is installed first instead, so do this. --initdb can be used multiple times with no ill side effects, but --updatedb is annoying and not actually useful (will automatically refresh every 4 hours, but starting from an empty directory it'll always fetch it anyway), so just remove it. Co-Authored-By: Jakub Jirutka <[email protected]>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a package has a pre-install script that adds users, the pre-install actually requires alpine-baselayout-data/busybox to successfully work, but this dependency isn't written anywhere.
After bringing this up on IRC rather than adding the dependency everywhere it was decided to make sure alpine-baselayout is installed first instead, so do this.
--initdb can be used multiple times with no ill side effects, but --updatedb is annoying and not actually useful (will automatically refresh every 4 hours, but starting from an empty directory it'll always fetch it anyway), so just remove it.
This fixes missing users on our systems because some package get installed too early