New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: stocks.get_stock_financial_summary raises ValueError and lxml.etree.ParserError #444

Open

p1ck4rd wants to merge 2 commits into alvarobartt:master from p1ck4rd:bugfix-get_stock_financial_summary

p1ck4rd commented Sep 14, 2021

Hi!
I found several bugs in the stocks.get_stock_financial_summary function:

if the table of the requested financial summary contains empty strings in values, ValueError is raised
if the /instruments/Financials/changesummaryreporttypeajax endpoint returns an empty body, lxml.etree.ParserError is raised

Here is the fix.

p1ck4rd added 2 commits

September 13, 2021 01:22


          fix ValueError on empty value in get_stock_financial_summary

c7a9bc3


          add check for empty response body to get_stock_financial_summary

a78a909

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet