Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(prettier): Add prettier, pr template #3

Merged
merged 6 commits into from
Jun 8, 2024
Merged

Conversation

alvinsj
Copy link
Owner

@alvinsj alvinsj commented Jun 8, 2024

Story: repo setup chore

  1. Why this change is required?
    • Improve code style
  2. What problem does it solve?
    • Add prettier to format files, eslint to fix semi, max-len, console

Implementation

  1. add prettier and config
  2. add eslint rules for max-len, no-console, no semicolon
  3. add lint step
  4. add pr template
  5. fix files to satisfy linter

Checklist

  • Fulfilled specs
  • Ensured code is readable
  • Consistency in architecture
  • Added Test: not required

@alvinsj alvinsj merged commit 71b2853 into main Jun 8, 2024
1 check passed
@alvinsj alvinsj deleted the chore--add-prettier branch June 8, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant