Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(login): add login redirect #5

Merged
merged 15 commits into from
Jun 9, 2024
Merged

feat(login): add login redirect #5

merged 15 commits into from
Jun 9, 2024

Conversation

alvinsj
Copy link
Owner

@alvinsj alvinsj commented Jun 9, 2024 •
edited
Loading

Story: Authorization redirect

  1. Why this change is required?
    • part of pkce flow
  2. What problem does it solve?
    • call authorization server to get pkce

Implementation

  1. minor refactoring, setup changes. e.g. move lib folder
  2. add LoginButton component
  3. simple styling
  4. add auth methods: createPKCECodes, redirectToLogin, getPKCEStatus

Note

  1. Skip cookie deletion to next PR because cookie should not be deleted without state change.

Checklist

  • Fulfilled specs
  • Ensured code is readable
  • Consistency in architecture
  • Added Test

@alvinsj alvinsj merged commit d0f1062 into main Jun 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alvinsj