Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tokens): access and refresh token #7

Merged
merged 8 commits into from
Jun 9, 2024
Merged

feat(tokens): access and refresh token #7

merged 8 commits into from
Jun 9, 2024

Conversation

alvinsj
Copy link
Owner

@alvinsj alvinsj commented Jun 9, 2024 •
edited
Loading

Story:

  1. Why this change is required?
    • part of refresh token rotation
  2. What problem does it solve?
    • implement refresh token rotation

Implementation

  1. refactor postToken to postTokenWithRefreshToken
  2. add getATWithRefreshToken vs getATWithAuthCode
  3. clean up, enable build in ci

Checklist

  • Fulfilled specs
  • Ensured code is readable
  • Consistency in architecture
  • Added Test

@alvinsj alvinsj merged commit 2cc227e into main Jun 9, 2024
1 check passed
@alvinsj alvinsj deleted the feat--refresh-token branch June 9, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alvinsj