Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use DESTDIR in Makefile #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yoshiyoshyosh
Copy link

@yoshiyoshyosh yoshiyoshyosh commented Aug 7, 2023

I wish to package this program for a distribution, and the build system for said distribution requires that package files are placed in a custom destination directory. it's general makefile convention to use DESTDIR in install and uninstall for staged installs such as this, and doing this shouldn't affect the normal way of compiling and installing on all operating systems.
additionally, I added install -m 775 -d $(DESTDIR)$(PREFIX)/bin such that the packaging build is able to install the files to the bin directory.

If this pr gets accepted, it would also be neat to have these same changes in all the other projects that use this build system so that I can package them as well (I can create PRs for these too if it'd be desired)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant