cleanup setting of TIM1_AUTORELOAD #116
Open
+20
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tridge
force-pushed
the
pr-TIM1_AUTORELOAD-cleanup
branch
4 times, most recently
from
c2a425c
to
49ff1c9
Compare
this replaces the manual setting with a calculation based on a 24kHz nominal PWM
tridge
force-pushed
the
pr-TIM1_AUTORELOAD-cleanup
branch
from
49ff1c9
to
9d6eb05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this replaces the manual setting with a calculation based on a 24kHz nominal PWM. It relies on the compiler calculating the value at compile time.
Note that the manual values used different rounding between the MCUs, so this does result in changed builds for some MCUs. I presume this won't matter, but please check carefully @AlkaMotors
Also, some of the values in the Mcu/xxxx/peripherals.c seemed to be incorrect. For example, F415 should be 6000 but it did the initialisation with 3000. It gets overridden in the main loop, but again please check I've understood correctly