Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IRC rotor sense #127

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

IRC rotor sense #127

wants to merge 2 commits into from

Conversation

freasy
Copy link
Collaborator

@freasy freasy commented Nov 24, 2024

First implementation on AM32 of IRC Rotor Sense feature.

With this feature you can set prop direction by spinning the prop in the correct direction. You will get an audio feedback.

If set once, it will be disabled. Do enable it again, clear the flag via the configurator or hold the dshot beacon, so the tone playes 10 times.

Scenarios:

  1. Spin prop -> plays tune -> detected direction change
  2. Spin prop again -> plays tune -> plays save tune -> direction changed and saved to eeprom -> rotor sense disabled
  3. Spin prop -> nothing is getting played -> already correct direction -> nothing happens
  4. Hold dshot beacon for 10 times played -> override rotor sense disable -> plays rotor sense tune -> rotor sense enabled

@howels
Copy link

howels commented Nov 25, 2024

Very cool, but we might need a more complex pattern than leaving dshot beacon to play 10x times, otherwise if we have quad stuck in a tree with beacon running (which tree?) we find quad, shake tree, quad falls. Now quad has some ESCs set to spin in different direction!
Maybe there's a more complex beacon on/off pattern which could be used to activate this? Like switching beacon on/off in quick succession some number of times. Maybe on/off 5 times in under 10s.

@freasy
Copy link
Collaborator Author

freasy commented Nov 25, 2024

Very cool, but we might need a more complex pattern than leaving dshot beacon to play 10x times, otherwise if we have quad stuck in a tree with beacon running (which tree?) we find quad, shake tree, quad falls. Now quad has some ESCs set to spin in different direction! Maybe there's a more complex beacon on/off pattern which could be used to activate this? Like switching beacon on/off in quick succession some number of times. Maybe on/off 5 times in under 10s.

you dont only have to let it beep for 10 times, you also have to spin it twice in the same direction, with a stop in between. You think that can happen randomly?
I also think, if you have your quad in a tree beeping away for that long and then falling down, you might want to investigate it before sending it again.

Also the dshot beacon unlock is only triggered by a user input, i would never let my quad beep for minutes straight. The "automatic" beacon is not triggering the override.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants