[Breaking] Make collections read-only #126
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed project version to 3.0.0-alpha.1 Added CHANGELOG entries for read-only error collection and read-only error metadata
zbyszekprasak
force-pushed
the
breaking/make-collections-read-only
branch
from
bd1c3d2 to
e25e460
Compare
zbyszekprasak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I have read that there was already two attempts to make objects immutable: #9 and #26. I propose third solution: replacing
List<Error>withReadOnlyCollection<Error>inErrorOr.ErrorsandDictionary<string, object>withReadOnlyDictionary<string, object>inError.Metadataproperty.It should not change much for existing code and does not have pitfall regarding lack of implicit conversion from interface. I was very focused not to break anything. I believe very conservative changes in unit tests proves that.
@amantinband please take a look and let me know if it is acceptable to put it in 3.0.0 version.