-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Add IQM Garnet device, retire OQC Lucy device #93
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to add some docs for the new device too but otherwise LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
==========================================
- Coverage 89.04% 89.00% -0.04%
==========================================
Files 36 36
Lines 3915 3929 +14
==========================================
+ Hits 3486 3497 +11
- Misses 429 432 +3 ☔ View full report in Codecov by Sentry. |
Waiting for #92 to be merged to fix the PyBraket-unit CI issues. |
Issue #, if available:
Description of changes:
Mark OQC Lucy device with
_
prefix since it is now retired from the Braket service. Add IQM Garnet device which recently launched.Testing done:
julia -e 'using Pkg; Pkg.test("Braket")'
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
git secrets
to make sure I did not commit any sensitive information (passwords or credentials)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.