feat: LocalQuantumTask to use ExecutionManager #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feature/execute-manager-local-quantum-task #657 +/- ##
============================================================================
Coverage 100.00% 100.00%
============================================================================
Files 121 122 +1
Lines 7891 7982 +91
Branches 1753 1770 +17
============================================================================
+ Hits 7891 7982 +91
|
speller26
reviewed
Aug 8, 2023
Comment on lines
74
to
76
| if hasattr(self, "_execute_manager"): | ||
| return self._execute_manager.cancel() | ||
| raise NotImplementedError("LocalQuantumTask does not support cancelling") |
There was a problem hiding this comment.
Instead of using hasattr, you can just do an if self._execute_manager check, and set it to None if not supplied
There was a problem hiding this comment.
getattr(self, "_execute_manager", None)?
Sai-prakash15
changed the title
speller26
reviewed
Aug 15, 2023
| """ | ||
| task = LocalQuantumTask() | ||
| task._execution_manager = execution_manager | ||
| task.async_result() |
There was a problem hiding this comment.
The task should be started without having to call async_result
Sai-prakash15
force-pushed
the
local-quantum-task-using-execute-manager
branch
from
d515025
to
a98648c
Compare
speller26
approved these changes
Aug 17, 2023
setup.py
Outdated
| @@ -28,7 +28,7 @@ | |||
| package_dir={"": "src"}, | |||
| install_requires=[ | |||
| "amazon-braket-schemas>=1.18.0", | |||
| "amazon-braket-default-simulator>=1.19.0", | |||
| "amazon-braket-default-simulator @ git+https://github.com/aws/amazon-braket-default-simulator-python.git@task-executor", # noqa | |||
There was a problem hiding this comment.
Once you've merged the default sim changes, remember to change this branch
Suggested change
| "amazon-braket-default-simulator @ git+https://github.com/aws/amazon-braket-default-simulator-python.git@task-executor", # noqa | |
| "amazon-braket-default-simulator @ git+https://github.com/aws/amazon-braket-default-simulator-python.git@feature/execute-manager", # noqa |
tox.ini
Outdated
| @@ -95,4 +95,4 @@ commands = | |||
| deps = | |||
| # If you need to test on a certain branch, add @<branch-name> after .git | |||
| git+https://github.com/aws/amazon-braket-schemas-python.git | |||
| git+https://github.com/aws/amazon-braket-default-simulator-python.git | |||
| git+https://github.com/aws/amazon-braket-default-simulator-python.git@task-executor | |||
There was a problem hiding this comment.
Here too
Suggested change
| git+https://github.com/aws/amazon-braket-default-simulator-python.git@task-executor | |
| git+https://github.com/aws/amazon-braket-default-simulator-python.git@feature/execute-manager |
Sai-prakash15
merged commit a7302cf
into
feature/execute-manager-local-quantum-task
16 of 28 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.