-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Usability: Warning when user calls "return" from their autoqasm entry point function #661
Merged
laurencap
merged 2 commits into
amazon-braket:feature/autoqasm
from
laurencap:lcap/aq-error-msgs-no-return-from-main
Aug 9, 2023
Merged
Usability: Warning when user calls "return" from their autoqasm entry point function #661
laurencap
merged 2 commits into
amazon-braket:feature/autoqasm
from
laurencap:lcap/aq-error-msgs-no-return-from-main
Aug 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurencap
changed the title
Warning when user calls "return" from their autoqasm entry point function
Usability: Warning when user calls "return" from their autoqasm entry point function
Aug 7, 2023
Codecov Report
@@ Coverage Diff @@
## feature/autoqasm #661 +/- ##
====================================================
- Coverage 99.92% 99.92% -0.01%
====================================================
Files 148 149 +1
Lines 8764 8752 -12
Branches 1879 1872 -7
====================================================
- Hits 8757 8745 -12
Misses 4 4
Partials 3 3
|
Looks great! |
yitchen-tim
approved these changes
Aug 8, 2023
rmshaffer
requested changes
Aug 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense overall, thanks for doing this! Left a few comments/questions.
src/braket/experimental/autoqasm/converters/return_statements.py
Outdated
Show resolved
Hide resolved
laurencap
force-pushed
the
lcap/aq-error-msgs-no-return-from-main
branch
from
August 8, 2023 18:43
3540278
to
378aeb9
Compare
rmshaffer
approved these changes
Aug 8, 2023
laurencap
merged commit Aug 9, 2023
97f6cab
into
amazon-braket:feature/autoqasm
27 of 28 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Warn if the called function returns a value
Testing done:
New unit tests
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.