Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added hardcoded user TCP timeout #145

Merged
merged 1 commit into from
May 6, 2024

Conversation

barshaul
Copy link

@barshaul barshaul commented May 5, 2024

We've encountered situations where the server's host fails to respond with an ACK to a transmitted message, causing the connection to hang on send_recv. To resolve this issue, we've implemented the socket2 set_tcp_user_timeout function.

Currently, this PR introduces a hardcoded timeout value of 5 seconds. However, in the future, when we have more resources, we plan to make it a configurable variable. You can find more information at redis-rs#1147.

@barshaul barshaul requested a review from ikolomi May 5, 2024 12:55
@barshaul
Copy link
Author

barshaul commented May 5, 2024

Linter fixed in: redis-rs#1180
Will cherry-pick it after it will be approved and merged

@barshaul barshaul merged commit d2f1607 into amazon-contributing:main May 6, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants