Merge pull request #458 from taylor-steve/input-inline-script

Remove inline_script attribute from markup
ambethia · Nov 27, 2024 · a13b9e0 · a13b9e0
2 parents 8e5ccae + ebc4d8c
commit a13b9e0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/lib/recaptcha/helpers.rb b/lib/recaptcha/helpers.rb
@@ -140,6 +140,7 @@ def self.to_message(_key, default)
       skip_script = (options.delete(:script) == false) || (options.delete(:external_script) == false)
       ui = options.delete(:ui)
       options.delete(:ignore_no_element)
+      options.delete(:inline_script)
 
       data_attribute_keys = [:badge, :theme, :type, :callback, :expired_callback, :error_callback, :size]
       data_attribute_keys << :tabindex unless ui == :button

diff --git a/test/client_helper_test.rb b/test/client_helper_test.rb
@@ -265,5 +265,12 @@
       output = recaptcha_v3(action: 'foo', ignore_no_element: false)
       refute_includes output, 'if (element !== null)'
     end
+
+    it 'does not output an inline script attribute' do
+      output = recaptcha_v3(action: 'foo', inline_script: true)
+      refute_includes output, 'inline_script'
+      output = recaptcha_v3(action: 'foo', inline_script: false)
+      refute_includes output, 'inline_script'
+    end
   end
 end